-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom/provisioned models in Bedrock #922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this addition. Will this make the drop down for all Bedrock models redundant? Do we need PR #923 ?
Tested the branch. For example:
... followed by issuing a query:
Suggested improvements:
- As can be seen in the example, you can enter the ARN or the model id. Say that in the string below the Model ID entry box?
- State the full form of ARN in parenthesis (Amazon Resource Name) and point to this page for reference: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference-arns.html
- The model provider asked for in the UI is always lower case, whereas in the model-ids table it is upper case. This may be confusing to the user, can we make this more clear if lower case is required?
- Add this feature/enhancement to the documentation?
No, it does not. We should continue to allow users to select Bedrock models by picking one from a list of options rather than force them to type out the model ID manually.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dlqqq for making the suggested changes. I have tested the new code with Model IDs but have not been able to test it with an ARN as yet (though my env/installation is updated with langchain-aws
0.1.13), which is needed. Am approving the code and documentation changes so far modulo testing for the ARN.
I have also assigned the new issue #924 to myself to expand the documentation.
@srdas Thank you! Note to other readers: this PR requires |
* add BedrockCustomProvider * pre-commit * format help text * show model ID field * edit BedrockCustomProvider help text * add mention of BedrockCustom in docs
Description
Adds support for custom/provisioned models on Amazon Bedrock. To do so:
Amazon Bedrock (custom/provisioned) :: *
in the chat model dropdown.anthropic.claude-v2
, then you should enteranthropic
(all lowercase) as the provider.ai21
,amazon
,anthropic
,cohere
,meta
, andmistral
.Demo